Catch invalid JSON response and raise Mollie::RequestError #181
Conversation
catch this and raise a Mollie::RequestError.
versions of Ruby.
|
I appreciate your contribution! We have, however, agreed internally not to merge this into the main line of the Client. We'll be fixing things so that those messages in HTML should appear a lot less frequently, and for 500/502/503 types of errors proper, well-formed JSON will be returned. And if they do appear, we wouldn't want the Client to raise a Again, many thanks for your contribution - please keep the feedback coming! In case you didn't know it yet, please consider joining our Developer Discord at https://discord.gg/mollie where I'll be available alongside many other Mollie team members to discuss this further :) |
|
Thanks for your quick reply. Makes a lot of sense what you say, so I completely understand this choice! |
This PR tries to handle invalid JSON responses (for e.g. 500 / 503 errors with HTML body) and raise a
Mollie::RequestErrorinstead.Occasionally, we see these errors in our logs, and it would be nice to be able to handle this in a clean way.
We are already handling
Mollie::RequestErrorin our application and I think it makes sense to raise that error for this scenario too.Must admit that it's an edge case, but it would still be nice to handle it like this and it would make our logs cleaner as well.